Teardowndebug #26

jimbr70 · 2017-05-04T21:58:51Z

Various fixes, runs in 8.0....

This change is

…ame vs os.environ var

…the message to "status cleared HH:MM:SS"

…he Globals resource.

… as the model and if none found, uses the self.details.ResourceModelName.

… alias-model vs model

… as the model and if none found, uses the self.details.ResourceModelName. fixes

• attribute_exist • get_attribute • set_attribute_value to handle being passed in an attribute name or the ending string of an attribute name which is preceeded by a period and a model in the case of a 2nd gen shell.

coveralls · 2017-05-04T21:59:42Z

Coverage decreased (-0.07%) to 16.042% when pulling c81fda8 on teardowndebug into 7e16ec2 on develop.

kalsky · 2017-05-04T22:14:28Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py

-            else:
-                self.model = self.details.ResourceModelName
-
+            self.model = self.get_attrib_value_ending_in_model()


you can use the previous logic now that you fixed the attribute_exist function

kalsky · 2017-05-04T22:14:56Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py

                return True
        return False

+    # -----------------------------------------
+    # -----------------------------------------


this function is not needed anymore

kalsky · 2017-05-04T22:19:30Z

sandbox_scripts/QualiEnvironmentUtils/Sandbox.py

@@ -20,9 +24,10 @@ def __init__(self, reservation_id, logger):
            """:type : logging.Logger"""
            self.api_session = helpers.get_api_session()
            self.id = reservation_id
-
+            self.owner = helpers.get_reservation_context_details().owner_user


the get_reservation_context_details result should be saved into a variable and then from there, you can take the owner and environment instead of calling this function twice.

also, now that we have the environmentPath, i would save it as well (self.environmentPath =..)

kalsky · 2017-05-04T22:21:24Z

sandbox_scripts/QualiEnvironmentUtils/Sandbox.py

        """
        Report on an error to the log file, output window is optional.There is also an option to raise the error up
        :param str error_message:  The error message you would like to present
        :param str log_message: The error message you would like to write to the log. Keep None to use the message param
        :param bool raise_error:  Do you want to throw an exception
        :param bool write_to_output_window:  Would you like to write the message to the output window
        """
+
+        emailresult = ''
+        if raise_error:


these 2 ifs can be one

kalsky · 2017-05-04T22:22:01Z

sandbox_scripts/QualiEnvironmentUtils/Sandbox.py

@@ -88,6 +115,51 @@ def report_info(self, message, log_message=None, write_to_output_window=False):
            self._write_message_to_output(message, SEVERITY_INFO)

    # ----------------------------------
+    def emailalert(self, subject, body, owner, ishtml=False, emailOwner=False):


change it to private (_email_alert)

kalsky

please review and fix based on the comments

jimbr70 · 2017-05-05T15:34:32Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 25 at r1 (raw file):

Previously, kalsky wrote…

you can use the previous logic now that you fixed the attribute_exist function

I don't think so. The code defaults to the resource Model if there is no attribute, so we should leave the current code.

Comments from Reviewable

jimbr70 · 2017-05-05T15:35:26Z

sandbox_scripts/QualiEnvironmentUtils/Resource.py, line 49 at r1 (raw file):

Previously, kalsky wrote…

this function is not needed anymore

Hmmm. This will return the resource Model if there is no attribute for it, so I think this is needed.

Comments from Reviewable

- call context once - add environment_path

…- init updated to handle.

trying to get the attribute error

trying again to print the exception details

coveralls · 2017-05-05T18:46:20Z

Coverage decreased (-0.4%) to 15.686% when pulling 1000180 on teardowndebug into 7e16ec2 on develop.

move cloudshell required packages to the test_requirements

move the cloudshell packages requirements to test_requirements

coveralls · 2017-05-05T18:52:51Z

Coverage decreased (-0.4%) to 15.686% when pulling 3194c5a on teardowndebug into 7e16ec2 on develop.

coveralls · 2017-05-05T18:54:50Z

Coverage decreased (-0.4%) to 15.686% when pulling 3194c5a on teardowndebug into 7e16ec2 on develop.

removed try/catch to debug exception

This reverts commit 6eabbf1.

coveralls · 2017-05-05T19:22:05Z

Coverage decreased (-0.1%) to 15.983% when pulling b471401 on teardowndebug into 7e16ec2 on develop.

jimbr70 added 25 commits April 24, 2017 11:00

import fix

e4af557

refactor fix

a8bfa49

refactor fix

1a9829c

try/import correction to set var

3b8733a

try/import correction to set var

6498acc

refactor fix

35c71e5

refactor fix

487a17b

removed a print

97fba27

sorted issue why this had to set env name previously. Now removed.

11585ba

Added test if blueprint name is empty - force error

a002f36

message consistency and now uses self.sandbox.Blueprint_name to set n…

1e63cec

…ame vs os.environ var

added test if pool = 0 then do not attempt to prpocess VMs

a4b0728

added test if pool = 0 then do not attempt to process network devices

c0413a4

just to help run debugging

e178657

updated clear all resoruce live status to set the status to Info and …

30650ad

…the message to "status cleared HH:MM:SS"

Added feature to email report_error conditions, using attributes in t…

43585fb

…he Globals resource.

created function to get the value of the attribute ending in ".Model"…

56f6a10

… as the model and if none found, uses the self.details.ResourceModelName.

edits, fixes to image_key and dict stuff relating to concrete name ve…

9e0d91c

… alias-model vs model

created function to get the value of the attribute ending in ".Model"…

5a12d61

… as the model and if none found, uses the self.details.ResourceModelName. fixes

fixes, updates for handling model attrib

62b03b7

change to

3c3a210

• attribute_exist • get_attribute • set_attribute_value to handle being passed in an attribute name or the ending string of an attribute name which is preceeded by a period and a model in the case of a 2nd gen shell.

changes to fix isues with test config, adding environmentPath,

fa997dc

changes to fix isues with test config, adding environmentPath,

0312028

cleaned appearance, added reporting info

1c36302

added freeze_gun

c81fda8

kalsky reviewed May 4, 2017

View reviewed changes

kalsky requested changes May 4, 2017

View reviewed changes

jimbr70 and others added 7 commits May 5, 2017 08:39

changes to init per yaniv

50eeb9f

- call context once - add environment_path

Merged two ifs to one, per Yaniv

d1a20f2

rename emailalert to _emailalert

3bd9812

removed function for handling attribute or attribute ending in Model …

fb30370

…- init updated to handle.

Update .travis.yml

90860eb

Update Sandbox.py

25ade05

trying to get the attribute error

Update Sandbox.py

1000180

trying again to print the exception details

kalsky added 2 commits May 5, 2017 11:50

Update .travis.yml

3818b05

move cloudshell required packages to the test_requirements

Update test_requirements.txt

3194c5a

move the cloudshell packages requirements to test_requirements

kalsky added 4 commits May 5, 2017 12:02

Update Sandbox.py

6eabbf1

removed try/catch to debug exception

Revert "Update Sandbox.py"

32b9e6d

This reverts commit 6eabbf1.

Reverted and removed the environment_path variable

4232efb

Fixed code alignment

b471401

kalsky approved these changes May 5, 2017

View reviewed changes

kalsky merged commit 381c113 into develop May 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Teardowndebug #26

Teardowndebug #26

jimbr70 commented May 4, 2017 •

edited by AlonSaggie

Loading

coveralls commented May 4, 2017

kalsky May 4, 2017

kalsky May 4, 2017

kalsky May 4, 2017

kalsky May 4, 2017

kalsky May 4, 2017

kalsky May 4, 2017

kalsky left a comment

jimbr70 commented May 5, 2017

jimbr70 commented May 5, 2017

coveralls commented May 5, 2017

coveralls commented May 5, 2017

coveralls commented May 5, 2017

coveralls commented May 5, 2017

Teardowndebug #26

Teardowndebug #26

Conversation

jimbr70 commented May 4, 2017 • edited by AlonSaggie Loading

coveralls commented May 4, 2017

kalsky May 4, 2017

Choose a reason for hiding this comment

kalsky May 4, 2017

Choose a reason for hiding this comment

kalsky May 4, 2017

Choose a reason for hiding this comment

kalsky May 4, 2017

Choose a reason for hiding this comment

kalsky May 4, 2017

Choose a reason for hiding this comment

kalsky May 4, 2017

Choose a reason for hiding this comment

kalsky left a comment

Choose a reason for hiding this comment

jimbr70 commented May 5, 2017

jimbr70 commented May 5, 2017

coveralls commented May 5, 2017

coveralls commented May 5, 2017

coveralls commented May 5, 2017

coveralls commented May 5, 2017

jimbr70 commented May 4, 2017 •

edited by AlonSaggie

Loading