Add missing exports for FileBox and Strong #168
Conversation
Also remove the file with duplicated and unused exports.
🦋 Changeset detectedLatest commit: 8e5b1e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for qualifyze-storybook ready! 🔨 Explore the source changes: 8e5b1e9 🔍 Inspect the deploy log: https://app.netlify.com/sites/qualifyze-storybook/deploys/611c47f54b53e300072190ae 😎 Browse the preview: https://deploy-preview-168--qualifyze-storybook.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8e5b1e9:
|
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vubogovich)
a discussion (no related file):
If everything is still working then I am really happy sir, it did seem strange to have duplicate export files for this package. Just assumed it was needed in the past, my bad.
Just one question though, how come these things where not exported in the past? you think they where just forgotten or do you think they are so atomic that they where intentionally designed not to be exported? Kinda link internal workings of the DS components or something
I will mark it as discussing as I would not want to block you on my ignorance 💃
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @vubogovich)
a discussion (no related file):
Previously, sirJiggles (Gareth Fuller) wrote…
If everything is still working then I am really happy sir, it did seem strange to have duplicate export files for this package. Just assumed it was needed in the past, my bad.
Just one question though, how come these things where not exported in the past? you think they where just forgotten or do you think they are so atomic that they where intentionally designed not to be exported? Kinda link internal workings of the DS components or something
I will mark it as discussing as I would not want to block you on my ignorance 💃
Looks like the second file with exports appeared in the early stage of the repo when it was extracted from the monorepo.
In monorepo SSOT for exports was the root index.js. Then in new repo before #43 SSOT shifted to components/index.js and the root index.js export * from there. And during #43 we got two files with explicit exports.
I guess later someone added new exports to components/index.js and not to the root index.js. That's why we should not have two lists.
Checked with @gregoralbrecht that it's ok to export FileBox and Strong.
What
Add missing exports for
FileBoxandStrong.Also remove the file with duplicated and unused exports. Looks like it's a left over from #43.
Why
Having two lists of component exports led to missing entries in the entry file.
Alternative: keep SSOT for component exports in
components/index.jsandexport *from there in the entry file.Who is affected
Those library consumers who imported components directly from
componentsfolder - hopefully nobody.This change is