Quickfix: Add disabled button styles to the button in the design system #329
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 27cdbbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This change is |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 27cdbbf:
|
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @jorgechiapello and @sirJiggles)
src/components/Button/index.jsx line 41 at r2 (raw file):
bg: 'primary.700', }, // '&:disabled': {
This is commented, maybe a leftover?
src/components/Button/index.stories.jsx line 44 at r2 (raw file):
<Inline> <Button disabled variant={variant} onClick={action('Button clicked')}> Cant touch this
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @jorgechiapello)
src/components/Button/index.jsx line 41 at r2 (raw file):
Previously, jorgechiapello (Jorge Alberto Chiapello) wrote…
This is commented, maybe a leftover?
Done.
src/components/Button/index.stories.jsx line 44 at r2 (raw file):
Previously, jorgechiapello (Jorge Alberto Chiapello) wrote…
Not gonna lie I half expected a rick roll 😆
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sirJiggles)
What❓
Here I added styles for the button in the design system so it can be disabled and a story to go with it.
Why 💁♀️
We need it in more and more places and having components to override this can be troublesome