Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #71

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Update README.md #71

merged 5 commits into from
Aug 24, 2023

Conversation

gabalafou
Copy link
Contributor

add instructions and screenshot on how to choose a theme from the menu bar

@gabalafou
Update README.md
5708302 
add instructions and screenshot on how to choose a theme from the menu bar
@github-actions
Copy link

Binder 👈 Launch a Binder on branch Quansight-Labs/jupyterlab-accessible-themes/gabalafou-patch-1

1 similar comment
@github-actions
Copy link

Binder 👈 Launch a Binder on branch Quansight-Labs/jupyterlab-accessible-themes/gabalafou-patch-1

@trallard trallard added the area: documentation 📖 Improvements or additions to documentation label Aug 24, 2023
@trallard
Copy link
Member

Thanks, @gabalafou - While you are updating the readme, can I ask you to sneak in a doc fix for the issue raised in #69 (comment) (only the doc, the rest will be tackled separately)

gabalafou and others added 2 commits August 24, 2023 07:05
@gabalafou
Update README.md
25a79a6 
snake-case everywhere: 
jupyterlab-accessible-themes
@pre-commit-ci
[pre-commit.ci] Apply automatic pre-commit fixes
81792d1
@github-actions
Copy link

Binder 👈 Launch a Binder on branch Quansight-Labs/jupyterlab-accessible-themes/gabalafou-patch-1

1 similar comment
@github-actions
Copy link

Binder 👈 Launch a Binder on branch Quansight-Labs/jupyterlab-accessible-themes/gabalafou-patch-1

@gabalafou
Update README.md
ad249fe 
missed a spot
@github-actions
Copy link

Binder 👈 Launch a Binder on branch Quansight-Labs/jupyterlab-accessible-themes/gabalafou-patch-1

@gabalafou
Copy link
Contributor Author

If I understand correctly, both the pip and conda commands should use snake-case for this package:

@trallard
Copy link
Member

Yep

steff456
steff456 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the readme @gabalafou! This PR looks good to me and ready to merge 🎉

@trallard trallard merged commit 32d7ae1 into main Aug 24, 2023
3 checks passed
@trallard trallard deleted the gabalafou-patch-1 branch August 24, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steff456 steff456 steff456 approved these changes

Assignees
No one assigned
Labels
area: documentation 📖 Improvements or additions to documentation
Projects
jupyter-a11y-tools 🛠
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabalafou @trallard @steff456