Fix arbitrary kwargs (fixes #171)

Quansight-Labs · Jun 26, 2019 · d179d70 · d179d70
1 parent 619e120
commit d179d70
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/uarray/_backend.py b/uarray/_backend.py
@@ -135,7 +135,6 @@ def inner(*args, **kwargs):
 
             a, kw = res
 
-            kw = {k: kw[k] for k in kw if k in opts}
             for k, v in kw_defaults.items():
                 if k in kw and kw[k] is v:
                     del kw[k]

diff --git a/unumpy/multimethods.py b/unumpy/multimethods.py
@@ -27,10 +27,14 @@ def ureduce(self, a, axis=0, dtype=None, out=None, keepdims=False):
 
 def _reduce_argreplacer(args, kwargs, arrays):
     def reduce(a, axis=None, dtype=None, out=None, keepdims=False):
-        return (
-            (arrays[0],),
-            dict(axis=axis, dtype=dtype, out=arrays[1], keepdims=keepdims),
-        )
+        kwargs = {}
+        if dtype is not None:
+            kwargs["dtype"] = dtype
+
+        if keepdims is not False:
+            kwargs["keepdims"] = keepdims
+
+        return ((arrays[0],), dict(axis=axis, out=arrays[1], **kwargs))
 
     return reduce(*args, **kwargs)