Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs are truncated #25

Closed
saulshanabrook opened this issue Nov 12, 2019 · 2 comments · Fixed by #27
Closed

Logs are truncated #25

saulshanabrook opened this issue Nov 12, 2019 · 2 comments · Fixed by #27
Assignees
@saulshanabrook
Labels
ibis-vega The project this belongs to reso:completed The issue was fixed type:bug Something isn't working

Comments

@saulshanabrook
Copy link
Contributor

Currently we are saving the Vega Lite and Vega specs to the open tracing logs, however they seem to be truncated at some number of characters. We should investigate this. If we can't save them to these logs, we should figure out another place to store them for debugging.
@saulshanabrook saulshanabrook added the type:bug Something isn't working label Nov 12, 2019
@saulshanabrook
Copy link
Contributor Author

We can increase the max log size: jaegertracing/jaeger-client-python#110

However this causes packets to be dropped since they are all sent in one UDP packet. We could get around this by switching to a HTTP connection instead of UDP one, but that isn't implemented yet in the Python client jaegertracing/jaeger-client-python#98

@saulshanabrook
Copy link
Contributor Author

I am trying to increase the max UDP size on my mac jaegertracing/jaeger-client-node#124 (comment)

@saulshanabrook saulshanabrook mentioned this issue Nov 12, 2019
Merged
@goanpeca goanpeca added ibis-vega The project this belongs to reso:completed The issue was fixed labels Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saulshanabrook saulshanabrook

Labels
ibis-vega The project this belongs to reso:completed The issue was fixed type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase log size limit Quansight/ibis-vega-transform
2 participants
@saulshanabrook @goanpeca