Increase log size limit #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
reviewed
Nov 14, 2019
goanpeca
reviewed
Nov 14, 2019
goanpeca
reviewed
Nov 14, 2019
README.md
Outdated
| lab extension to see the Jaeger icon in the launcher. | ||
|
|
||
|
|
||
| Then open up the Jaeger tracer before running the notebook, run some visualizations and look at the traces. |
There was a problem hiding this comment.
If we use the extension, all this should be automatic no?
There was a problem hiding this comment.
I will edit this to be more detailed.
There was a problem hiding this comment.
Does it make more sense now?
goanpeca
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Looks good @saulshanabrook. Just left a couple of questions
goanpeca
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25 by increasing max log size limit so we can see generated Vega and Vega Lite specs for debugging.