Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ingress overrides behaviour #1420

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Update Ingress overrides behaviour #1420

merged 1 commit into from
Aug 27, 2022

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented Aug 26, 2022

related to #1418

Changes introduced in this PR:

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

Tested with local deployment and inspect that the proper values were set:

[terraform]:   # module.kubernetes-ingress.kubernetes_service.main will be created
[terraform]:   + resource "kubernetes_service" "main" {
[terraform]:       + id                     = (known after apply)
[terraform]:       + status                 = (known after apply)
[terraform]:       + wait_for_load_balancer = true
[terraform]: 
[terraform]:       + metadata {
[terraform]:           + annotations      = {
[terraform]:               + "networking.gke.io/internal-load-balancer-subnet" = "pre-existing-subnet"
[terraform]:               + "networking.gke.io/load-balancer-type"            = "Internal"
[terraform]:             }
[terraform]:           + generation       = (known after apply)
[terraform]:           + name             = "qhub-traefik-ingress"
[terraform]:           + namespace        = "dev"
[terraform]:           + resource_version = (known after apply)
[terraform]:           + uid              = (known after apply)
[terraform]:         }

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me sir 💯

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @viniciusdc ! Looks great to me.

@costrouc costrouc merged commit 40470f1 into main Aug 27, 2022
@costrouc costrouc deleted the 1418-lb-annotations branch August 27, 2022 04:32
@iameskild iameskild added this to the Release v0.4.4 milestone Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants