fix chroma only retrieving one source #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Oct 29, 2023
| @@ -96,19 +96,19 @@ def retrieve( | |||
| include=["distances", "metadatas", "documents"], | |||
| ) | |||
|
|
|||
| num_results = len(result["ids"]) | |||
| num_results = len(result["ids"][0]) | |||
There was a problem hiding this comment.
This is the actual fix. For some reason, result["ids"] is a list, which contains nothing but another list, which ultimately holds the IDs we are after here.
| result = { | ||
| key: [None] * num_results if value is None else value[0] # type: ignore[index] | ||
| for key, value in result.items() | ||
| } | ||
| # dict of lists -> list of dicts | ||
| results = [ | ||
| {key: value[idx] for key, value in result.items()} | ||
| {key[:-1]: value[idx] for key, value in result.items()} |
There was a problem hiding this comment.
Ignoring the last character here drops the "s" and thus makes the keys singular. Might sound nitpicky here, but I found myself confused when looking at the source again and having something like id=result["ids"] in the Source instantiation below.
dharhas
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline report from @dharhas.