allow API token secret to be set through env var #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrotsmnrd
approved these changes
Nov 1, 2023
pierrotsmnrd
reviewed
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, restarting the API will invalidate all active tokens up to this point, since they API has a new secret to verify them. The old default behavior is preserved. Meaning, if you don't set the
RAGNA_DEMO_AUTHENTICATION_SECRETenv var, we'll use a random on that changes with every start of the API.This also removes the option to set the document upload secret for local documents through the configuration file. We shouldn't have done that in the first place. It can still be set through the same env var
RAGNA_API_DOCUMENT_UPLOAD_SECRETas before.