Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supply document name as part of the request body rather than query #186

Merged
merged 2 commits into from
Dec 7, 2023
Merged

supply document name as part of the request body rather than query #186

merged 2 commits into from
Dec 7, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Nov 8, 2023

Fixes #172. Now we need to PUT the document to upload it. I need to check if this works with S3 before we can merge.

pierrotsmnrd
pierrotsmnrd approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@pierrotsmnrd pierrotsmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code and it looks good to me. I have also done manual tests. The JSON.stringify part lead me to try with a filename that contains special chars, and it all works.

@pmeier pmeier marked this pull request as ready for review December 7, 2023 15:09
@pmeier pmeier merged commit 2921079 into main Dec 7, 2023
10 checks passed
@pmeier pmeier deleted the api-body branch December 7, 2023 15:12
pmeier added a commit that referenced this pull request Dec 7, 2023
@pmeier
supply document name as part of the request body rather than query (#186
f650cdd 
)
@pmeier pmeier mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrotsmnrd pierrotsmnrd pierrotsmnrd approved these changes

Assignees
No one assigned
Labels
area: rest-api 💻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - 500 Internal Server Error Upon Ingestion of Certain Files
2 participants
@pmeier @pierrotsmnrd