Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LanceDB retrieval #195

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix LanceDB retrieval #195

merged 1 commit into from
Nov 10, 2023

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Nov 10, 2023

Fixes #193.

<rant>
What a horrible UX that just let's the user pass nothing for the query in a vector search. I mean, what is the vector search supposed to do if it has nothing to compare against. 馃槨
</rant>

@pmeier pmeier merged commit 8d14f87 into main Nov 10, 2023
10 checks passed
@pmeier pmeier deleted the fix-lance branch November 10, 2023 22:15
pmeier added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - lancedb retrieval unlikely to be working as expected
1 participant