New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code quality improvements of the API wrapper #250

Merged

pmeier merged 1 commit into main from ui-code-quality

Dec 14, 2023

Member

pmeier commented Dec 12, 2023

ApiWrapper.start_chat is not called from anywhere but ApiWrapper.start_and_prepare. Since .start_chat is a single statement, I just inlined it.
Apart form the fact that one should not use mutable default values, ApiWrapper.start_and_prepare is only ever called with params. Thus, I removed the params={} default.
emoji.emojize handles multiple substitutions in a string just fine. There is no need for us to do it manually.


          code quality improvements of the API wrapper

c713618

pmeier added the area: web-ui 💻 label

pmeier merged commit 2474f1c into main

10 checks passed

pmeier deleted the ui-code-quality branch

December 14, 2023 14:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment