Fix rendering of chat info button #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
reviewed
Dec 18, 2023
Currently a new chat info button is created whenever the UI is updated. This creates a problem as when the UI is re-rendered it is still referencing the original button (which has not actually been updated). To fix this issue a button should only be created once and then updated in place prior to each re-render.
nenb
force-pushed
the
chat-info-button-correct-render
branch
from
9e91b4c to
948e27c
Compare
Contributor
Author
|
@pmeier I've added your suggestions and I think this should be ready for merge now. |
pmeier
added a commit
that referenced
this pull request
Dec 20, 2023
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #229.
Currently a new chat info button is created whenever the UI is updated. This creates a problem as when the UI is re-rendered it is still referencing the original button (which has not actually been updated). To fix this issue a button should only be created once and then updated in place prior to each re-render.