Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove invalid font CSS declaration #308

Merged
merged 2 commits into from
Feb 7, 2024
Merged

remove invalid font CSS declaration #308

merged 2 commits into from
Feb 7, 2024

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Feb 2, 2024

Fixes #230. https://rsms.me/ does not contain any CSS. In the documentation it is listed as "preconnect", i.e. just telling the browser to connect to this host as soon as possible rather than only connecting on demand.

@pmeier
Copy link
Member Author

pmeier commented Feb 2, 2024

The failures here are unrelated. lancedb==5.0.2 was released an hour ago and that now depends on polars. However, our envs are cached on a daily basis so polars was not pulled in yet.

Copy link
Contributor

@pierrotsmnrd pierrotsmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@pmeier pmeier merged commit 1758816 into main Feb 7, 2024
4 of 5 checks passed
@pmeier pmeier deleted the font-css branch February 7, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stylesheet is not loaded because of wrong MIME type
2 participants