Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only send sources on first chunk when streaming #317

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Feb 12, 2024

I've set out to do this from the start in #215 (comment), but I forgot about it.

Copy link
Contributor

@nenb nenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This makes a lot of sense. I'll have a little time over the next few days, so I'll also push a small test to prevent regressions in this in the future. (Pushing a test myself will help me to understand any potential edge cases here, which I may have missed from eyeballing the code in the review!)

@pmeier
Copy link
Member Author

pmeier commented Feb 19, 2024

I'll have a little time over the next few days, so I'll also push a small test to prevent regressions in this in the future. (Pushing a test myself will help me to understand any potential edge cases here, which I may have missed from eyeballing the code in the review!)

Thanks a ton 🙏 I know I have been way to lax on adding tests. I'll get on that in the next couple of weeks.

However, let's add the tests in a follow-up PR. I need this one for #89.

@pmeier pmeier merged commit 8727869 into main Feb 19, 2024
10 checks passed
@pmeier pmeier deleted the stream-sources-api branch February 19, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants