Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor config docs #318

Merged
merged 11 commits into from
Feb 19, 2024
Merged

refactor config docs #318

merged 11 commits into from
Feb 19, 2024

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Feb 13, 2024

Fixes #182. Blocked by #316. This PR removes the image that displayed the configuration wizard as I think it adds very little value. Instead, I've added an explanation for all configuration options.

@pmeier pmeier added area: documentation 📖 Improvements or additions to documentation pr-status: blocked 🚫 labels Feb 13, 2024
Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @pmeier!

I've shared some minor suggestions, looks good to me overall :)

docs/references/config.md Outdated Show resolved Hide resolved
docs/references/config.md Outdated Show resolved Hide resolved
docs/references/config.md Outdated Show resolved Hide resolved
docs/references/config.md Outdated Show resolved Hide resolved
docs/references/config.md Outdated Show resolved Hide resolved
pmeier and others added 2 commits February 19, 2024 15:35
Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@pmeier pmeier merged commit b3cc95a into main Feb 19, 2024
10 checks passed
@pmeier pmeier deleted the config-docs branch February 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configuration file in documentation is out of date
2 participants