Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate call to answer method when not streaming #325

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Remove duplicate call to answer method when not streaming #325

merged 2 commits into from
Feb 15, 2024

Conversation

nenb
Copy link
Contributor

@nenb nenb commented Feb 15, 2024 •
edited

await core_chat.answer(...) is also called again inside the non-streaming block of code.

@nenb nenb requested a review from pmeier February 15, 2024 12:44
pmeier
pmeier approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmeier pmeier merged commit 3780d2b into Quansight:main Feb 15, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nenb @pmeier