Add option to ignore unavailable components #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Dockerfile ragna/deploy/_api/core.py ragna/deploy/_cli/core.py
aktech
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
This looks good to me, I tried running locally and it worked for me.
I have a couple of nitpick comments, nothing blocking merge. I would also add a quick smoke test in the CI (docker run ..) after the docker image is built for end to end testing, but this is also not blocking, but really really nice to have as that's the quickest interface for users to quickly try ragna.
We currently have ragna/.github/workflows/docker.yml Lines 107 to 108 in dbc7be7 This of course is only a minimal check, but maybe what you are looking for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #332.