Skip to content

Conversation

@pmeier
Copy link
Member

@pmeier pmeier commented Feb 20, 2024

Closes #332.

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I tried running locally and it worked for me.

I have a couple of nitpick comments, nothing blocking merge. I would also add a quick smoke test in the CI (docker run ..) after the docker image is built for end to end testing, but this is also not blocking, but really really nice to have as that's the quickest interface for users to quickly try ragna.

@pmeier
Copy link
Member Author

pmeier commented Mar 7, 2024

I would also add a quick smoke test in the CI (docker run ..) after the docker image is built for end to end testing

We currently have

- name: Smoke test
run: docker run ${{ steps.metadata.outputs.tagged-image-name }} --version

This of course is only a minimal check, but maybe what you are looking for?

@aktech aktech merged commit 8b0b0f3 into main Mar 7, 2024
@aktech aktech deleted the disable-unavailable-components branch March 7, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add flag to disable unavailable components for the API / UI

3 participants