Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use root_path in api.url #346

Merged
merged 3 commits into from
Mar 6, 2024
Merged

use root_path in api.url #346

merged 3 commits into from
Mar 6, 2024

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Mar 6, 2024

Supersedes #305. After an offline discussion with @aktech we agreed that it preferable to include the config.api.root_path in config.api.url. While this means we have this we have this information duplicated in the default configuration, this has two upsides:

  1. We don't need to join the URL and the root path everywhere in our code base.
  2. It opens up the possibility to route an app deployed with a root path to a top level domain without one.

@pmeier pmeier requested a review from aktech March 6, 2024 12:10
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, verified it works.

@aktech aktech merged commit dbc7be7 into main Mar 6, 2024
11 checks passed
@aktech aktech deleted the root-path-url branch March 6, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants