improve error handling for builtin assistants #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Mar 11, 2024
| @@ -103,10 +103,11 @@ testpaths = [ | |||
| ] | |||
| filterwarnings = [ | |||
| "error", | |||
| "ignore::ResourceWarning", | |||
There was a problem hiding this comment.
You can find plenty of issues all over the web that have problems with unclosed resource warnings when using pytest. We are properly using context managers everywhere, so whatever warning is happening in the test suite stems from it rather than the code we are trying to test.
pmeier
commented
Mar 11, 2024
| ] | ||
|
|
||
|
|
||
| @skip_on_windows |
There was a problem hiding this comment.
I tried multiple things now, but got nothing to work. All data points to the test code being the problem rather than the code that is tested here. Let's ignore this for now. Maybe someone else has more insights later.
nenb
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spend almost an hour today trying to find a bug that wasn't there, because we didn't raise a proper error when our API call failed.