Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic: DataProvider #24

Closed
wants to merge 4 commits into from

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Feb 27, 2024

Description

  • GetHistory() skeleton to make historical requests.
  • Delisting\Mapped validation on Symbol in history requests.

Related Issue

N/A

Motivation and Context

Impact:

  • Enhances the functionality and completeness of the future implementation.
  • Ensures consistency and coherence within the repository.
  • Facilitates smoother development processes and reduces the risk of future issues.

Proposed Changes:

  • Add the missed part to the future implementation, ensuring proper documentation and integration with existing codebase.
  • Update relevant documentation to reflect the inclusion of this component.

Requires Documentation Change

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@Romazes Romazes closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants