Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyNotFoundException in Cash.EnsureCurrencyDataFeed #4610

Merged

Conversation

StefanoRaggi
Copy link
Contributor

Description

  • Added a missing dictionary check in Cash.EnsureCurrencyDataFeed

Related Issue

Closes #4609

Motivation and Context

  • Better error message for unsupported currencies

Requires Documentation Change

No

How Has This Been Tested?

  • Live algorithm deployed to IB
  • New unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero Martin-Molinero merged commit 4c04efc into master Aug 6, 2020
@StefanoRaggi StefanoRaggi deleted the bug-4609-keynotfoundexception-unsupported-currencies branch August 6, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyNotFoundException in Cash.EnsureCurrencyDataFeed with unsupported currencies
2 participants