Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification targets and events to live packet #5210

Merged
merged 5 commits into from Jan 27, 2021

Conversation

Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented Jan 22, 2021

Description

  • Add notification targets and events to live packet. Adding unit tests

Related Issue

Closes #4270

Motivation and Context

  • Notifications driven by job packet

Requires Documentation Change

N/A

How Has This Been Tested?

Added unit tests. Sanity tested existing use case

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero Martin-Molinero force-pushed the feature-builtin-notification-system branch from 9a76335 to 1c9ee93 Compare January 22, 2021 15:59
- Add notification targets and events to live packet. Adding unit tests
- Adding ShortToString implemnetation of OrderEvent and Insight
- Add Web notification headers
@Martin-Molinero Martin-Molinero force-pushed the feature-builtin-notification-system branch from 5dcf758 to 05722b9 Compare January 25, 2021 15:36
@Martin-Molinero Martin-Molinero merged commit e91af08 into master Jan 27, 2021
@Martin-Molinero Martin-Molinero deleted the feature-builtin-notification-system branch January 27, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Optional Parameter to NotificationManager.Web To Allow Headers
1 participant