Feature implement ExchangeInfoDownloader #6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjra2611
force-pushed
the
feature-implement-IExchangeInfoDownloader-gdax
branch
from
3b9ac59
to
b8414ce
Compare
Martin-Molinero
requested changes
Feb 17, 2022
Tests/Brokerages/Bitfinex/BitfinexBrokerageExchangeInfoTests.cs
Outdated
Show resolved
Hide resolved
Martin-Molinero
approved these changes
Feb 21, 2022
rjra2611
force-pushed
the
feature-implement-IExchangeInfoDownloader-gdax
branch
from
80d857b
to
66ca347
Compare
AlexCatarino
pushed a commit
to AlexCatarino/Lean
that referenced
this pull request
Mar 17, 2022
* add gdax exchange info downloader * add downloader method to program] * fetch currency description * change definition to include headers * use extension method to make request * remove log from test * replace WebRequest * cleanup * use relevant name * implement IExchangeInfoDownloader for bitfinex, initial commit * add default values * use default market value * use correct attribute for lotsize * don't skip missing values * handle multiple downloaders * add gdax and bitfinex exchange downloader * follow LEAN data directory structure * update SPDB * order tickers * order tickers * add exchange info downloader test template * delete files * update SPDB * use currency mapping * update bitfinex symbols * update currency mapping * sort result after old currency symbols are used * use market of the respective brokerage * no more unknown symbol * change minimum order size value * direct conversion possible * update bitfinex symbols * change user-agent * add test for indirect conversion * update stats
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IExchangeInfoDownloaderfor GDAX brokerageGDAXExchangeInfoDownloaderExtensions.DownloadDatato accept custom headersRelated Issue
Motivation and Context
Automate the process to update the symbol properties database
Requires Documentation Change
No
How Has This Been Tested?
Tests have been added
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>