New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fillForward
parameter to History
methods
#7180
Merged
Martin-Molinero
merged 14 commits into
QuantConnect:master
from
jhonabreul:bug-6750-missing-history-parameters
Apr 17, 2023
Merged
Add fillForward
parameter to History
methods
#7180
Martin-Molinero
merged 14 commits into
QuantConnect:master
from
jhonabreul:bug-6750-missing-history-parameters
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New name if fillDataForward as in the Add*Security API to standarize parameters naming
Using the shorter fillForward in every API
Martin-Molinero
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🙌
This was referenced Apr 17, 2023
7 tasks
This was referenced Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an effort to add all the configuration parameters (fill forward, extended market hours, data mapping and normalization mode, and contract depth offset) to the
History
API, this is the first step towards that goal. Parameters will be added one by one, beingfillForward
the first one.Related Issue
Part of #6750
Motivation and Context
Requires Documentation Change
It could require updating the
History
API documentation.How Has This Been Tested?
Unit tests.
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>