Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper: Method for Retrieving Historical Ticker Symbols #7826

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Feb 29, 2024

Description

This pull request introduces a new helper method for retrieving historical ticker symbols from a provider that supports very old data, including cases where tickers have been restructured.

For instance:

image

Related Issue

N/A

Motivation and Context

The motivation behind this addition is to facilitate access to historical ticker symbols, which can be critical for various applications such as financial analysis or data processing. The method addresses scenarios where tickers may have undergone restructuring over time, ensuring accurate retrieval of historical data.

Requires Documentation Change

N/A

How Has This Been Tested?

The new helper method has been extensively tested to ensure its accuracy and reliability. Test cases cover various scenarios, including different start date inputs and ticker restructuring events. Additionally, edge cases have been considered to validate the method's behavior under different conditions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 💪, shared minor comment in slack, map date is the last date a ticker was used, so should consider the entire date for it in exchange tz

@Romazes Romazes force-pushed the feature-resolve-renamed-symbol-for-history-request branch from 052dd05 to 17c885a Compare March 8, 2024 20:39
@Romazes Romazes deleted the feature-resolve-renamed-symbol-for-history-request branch March 26, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants