-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper: Method for Retrieving Historical Ticker Symbols #7826
Merged
Martin-Molinero
merged 21 commits into
QuantConnect:master
from
Romazes:feature-resolve-renamed-symbol-for-history-request
Mar 11, 2024
Merged
Helper: Method for Retrieving Historical Ticker Symbols #7826
Martin-Molinero
merged 21 commits into
QuantConnect:master
from
Romazes:feature-resolve-renamed-symbol-for-history-request
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
11 tasks
27cd8ba
to
3294a47
Compare
Martin-Molinero
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 💪, shared minor comment in slack, map date is the last date a ticker was used, so should consider the entire date for it in exchange tz
feat: test refactor: test a little bit neat
feat: test refactor: RetrieveSymbolHistoricalDefinitions
refactor: change location of extension refactor: change location of test extension
feat: add Future Symbol tests
feat: add TickerDateRange struct instead of Tuple fix: test
fix: test description
052dd05
to
17c885a
Compare
test: several new test cases
Martin-Molinero
approved these changes
Mar 11, 2024
Martin-Molinero
approved these changes
Mar 11, 2024
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new helper method for retrieving historical ticker symbols from a provider that supports very old data, including cases where tickers have been restructured.
For instance:
Related Issue
N/A
Motivation and Context
The motivation behind this addition is to facilitate access to historical ticker symbols, which can be critical for various applications such as financial analysis or data processing. The method addresses scenarios where tickers may have undergone restructuring over time, ensuring accurate retrieval of historical data.
Requires Documentation Change
N/A
How Has This Been Tested?
The new helper method has been extensively tested to ensure its accuracy and reliability. Test cases cover various scenarios, including different start date inputs and ticker restructuring events. Additionally, edge cases have been considered to validate the method's behavior under different conditions.
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>