Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh symbol properties using right type for security #8087

Conversation

jhonabreul
Copy link
Collaborator

Description

Follow up for #8083.

On a SPDB refresh in live trading, the SymbolProperties class must be the right one for the security type: OptionSymbolProperties for options, IndexOptionSymbolProperties for index options, and the base SymbolProperties for the rest.

Related Issue

Closes #8085

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

  • Unit tests
  • Live paper trading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@jaredbroad jaredbroad merged commit a159950 into QuantConnect:master Jun 11, 2024
6 of 7 checks passed
@jhonabreul jhonabreul deleted the bug-8085-symbol-properties-refresh-to-right-type branch June 11, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled Invalid Cast Error in IndexOption
2 participants