Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Remove LEAN warnings #8089

Conversation

Marinovsky
Copy link
Collaborator

@Marinovsky Marinovsky commented Jun 13, 2024

Description

Removed the following warnings:

Fixed these warnings:

Related Issue

Closes #5155

Motivation and Context

With this change we will ignore the warnings that are acceptable in our codebase to reduce build logs and improve visibility into new warnings and errors

Requires Documentation Change

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Marinovsky Marinovsky changed the title Fix/Remove/Ignore LEAN warnings Fix/Remove LEAN warnings Jun 13, 2024
@Martin-Molinero
Copy link
Member

This PR is too big to review & ship, it will be resubmitted 1 PR at the time with a reasonable amount of changes as requested, ~100 fixes per PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Warnings Overload
2 participants