Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4/4 of CA2201 warnings #8103

Merged

Conversation

Marinovsky
Copy link
Collaborator

Description

Fix 4/4 of CA2201 warnings creating a new class called TestException

CA2201: Do not raise reserved exception types (see https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Related Issue

Partially closes #5155

Motivation and Context

With this change LEAN will have less CA2201 warnings

Requires Documentation Change

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Marinovsky Marinovsky force-pushed the bug-5155-FixWarningsByParts4 branch from 4031239 to 28431be Compare June 24, 2024 22:36
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit 5699fa4 into QuantConnect:master Jun 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Warnings Overload
2 participants