Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix bug in pure_nash #75

Closed
wants to merge 2 commits into from
Closed

FIX: Fix bug in pure_nash #75

wants to merge 2 commits into from

Conversation

QBatista
Copy link
Member

@QBatista QBatista commented Mar 8, 2018

Should we use action_profile instead of action to be consistent with the type?

Close #73

@oyamad
Copy link
Member

oyamad commented Mar 8, 2018

The added is_nash doesn't have tol. Will you incorporate this PR into #74 (and close this)?

Should we use action_profile instead of action to be consistent with the type?

Yes, good point.

We don't need a docstring for this method: the general N case already covers this case.


n = 3
g1 = NormalFormGame(Player(collect(1:n)))
@test pure_nash(g1) == [(3,)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Don't put this test in test_normal_form_game.jl.
  • [(3,)] -> [(n,)]

@codecov-io
Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #75 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #75      +/-   ##
=========================================
+ Coverage   94.28%   94.3%   +0.01%     
=========================================
  Files           5       5              
  Lines         350     351       +1     
=========================================
+ Hits          330     331       +1     
  Misses         20      20
Impacted Files Coverage Δ
src/normal_form_game.jl 92.3% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47bc1b...c91a515. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 8, 2018

Coverage Status

Coverage increased (+0.02%) to 94.302% when pulling c91a515 on pure_nash_bug into b47bc1b on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants