Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on matplotlib #262

Closed
jstac opened this issue Sep 21, 2016 · 8 comments
Closed

Remove dependence on matplotlib #262

jstac opened this issue Sep 21, 2016 · 8 comments
Labels

Comments

@jstac
Copy link
Contributor

jstac commented Sep 21, 2016

At least some modules pull in matplotlib, such as this one:

https://github.com/QuantEcon/QuantEcon.py/blob/master/quantecon/arma.py

Let's get rid of this dependency if possible. One way to do this when we have functions that generate plots is to have them take an axes instance as an argument and write to it.

(This could be added to the contributions style guide.)

@davidrpugh
Copy link
Contributor

davidrpugh commented Sep 21, 2016

@jstac I agree with the sentiment, but worry that writing functions and methods that depend on an axes instance leaves us with an implicit dependency on matplotlib rather than the explicit dependency that we have now.

How much code is actually using plotting functionality? There are so many good plotting libraries out there and given that preferences over optimal plotting libraries are quite idiosyncratic (i.e., there is no dominant visualization library) perhaps we should consider removing all plotting code.

Code we have now could be moved to examples that demonstrate usage of the core library. This would leave us with less code to maintain in the long run and leave the choice of data viz tooling entirely to the end user.

@jstac
Copy link
Contributor Author

jstac commented Sep 21, 2016

@davidrpugh That's probably a good idea. I just ran a search and only arma.py is importing Matplotlib. If there's no objection, then I'll pull it out and put it in QuantEcon.applications.

Thanks ;-)

@cc7768
Copy link
Member

cc7768 commented Mar 11, 2017

Was just thinking about this -- Long story which I'll generate another thread for. It doesn't look like we ever removed this dependency. Are people still in favor of removing this dep? (I am)

@jstac
Copy link
Contributor Author

jstac commented Mar 11, 2017

@cc7768 Yes, definitely, I just haven't had time...

@davidrpugh
Copy link
Contributor

Agreed!

@oyamad
Copy link
Member

oyamad commented Aug 25, 2017

Done by #330 and #331.

@natashawatkins
Copy link
Member

Seems we can close this @mmcky? matplotlib only returns files in the docs and something related to sphinxext

@mmcky
Copy link
Contributor

mmcky commented Dec 4, 2017

indeed. Thanks @natashawatkins

@mmcky mmcky closed this as completed Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants