Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update the software stack to use latest versions #100

Merged
merged 9 commits into from
Nov 23, 2021
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Oct 18, 2021

This PR updates the software stack

  • anaconda
  • jupyter-book
  • quantecon-book-theme
  • sphinx-exercise
  • sphinx-tojupyter

@mmcky
Copy link
Contributor Author

mmcky commented Oct 18, 2021

@shlff would you have 10 minutes to cast an eye over the generated preview above and let me know if you spot any issues (as a double check). This is a big upgrade to the software so it would be great to get a second opinion on:

  • html
  • download ipynb
  • download pdf
  • check argmax and argmin rendering in mathjax (html)

@mmcky
Copy link
Contributor Author

mmcky commented Oct 18, 2021

@AakashGfude it looks like the pdf build on this update is not working with error

I did a clean build and this is no longer an issue -- must have been a stale cache on my local.

@github-actions github-actions bot temporarily deployed to commit October 18, 2021 05:13 Inactive
@github-actions github-actions bot temporarily deployed to commit October 18, 2021 05:21 Inactive
@shlff
Copy link
Member

shlff commented Oct 26, 2021

@shlff would you have 10 minutes to cast an eye over the generated preview above and let me know if you spot any issues (as a double check). This is a big upgrade to the software so it would be great to get a second opinion on:

  • html
  • download ipynb
  • download pdf
  • check argmax and argmin rendering in mathjax (html)

Thanks @mmcky . I can still observe the issue of argmax and argmin rendering in mathjax (HTML) in the following lecture (HTML only):

Please find the screenshots:
Screen Shot 2021-10-26 at 11 22 57 am
Screen Shot 2021-10-26 at 11 23 15 am

And some math expressions are not compiled in the following lecture (in HTML, pdf, but not in notebook):

Please find the screenshots (HTML and PDF respectively):
Screen Shot 2021-10-26 at 11 23 35 am
Screen Shot 2021-10-26 at 11 24 12 am

@github-actions github-actions bot temporarily deployed to commit November 19, 2021 04:49 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Nov 19, 2021

thanks for these comments @shlff I will look into them.

@github-actions github-actions bot temporarily deployed to commit November 22, 2021 00:03 Inactive
@github-actions github-actions bot temporarily deployed to commit November 22, 2021 02:10 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Nov 22, 2021

@AakashGfude any idea why these argmin and argmax are not getting rendered by mathjax. It looks like they are defined in the quantecon-book-theme==0.3.0 (which I am using to build) and I have used the inspector to see they are "loaded" in the top level Mathjax object. Is this an svg thing?

https://619afbecc6e9b4374cbbd7c6--wonderful-lalande-528d1c.netlify.app/orth_proj.html

@github-actions github-actions bot temporarily deployed to commit November 22, 2021 02:23 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Nov 22, 2021

@github-actions github-actions bot temporarily deployed to commit November 22, 2021 02:58 Inactive
@github-actions github-actions bot temporarily deployed to commit November 22, 2021 04:54 Inactive
@github-actions github-actions bot temporarily deployed to commit November 22, 2021 05:00 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Nov 22, 2021

thanks @AakashGfude the config just needed a little tweaking in _config.yml

But looks good now:

https://619b2287bf0f7454e6b041d5--wonderful-lalande-528d1c.netlify.app/orth_proj.html#solution

@mmcky
Copy link
Contributor Author

mmcky commented Nov 22, 2021

@shlff I think we have resolved all your comments. Thanks for looking at the previews. I might merge this later this week so let me know if you have any other comments etc. Thanks.

@mmcky mmcky merged commit 7ac5620 into main Nov 23, 2021
@mmcky mmcky deleted the upgrade-software branch November 23, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants