-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Performance Evaluation to Numpy Exercise #235
Conversation
thanks @HumphreyYang I think this is a good addition. |
@jstac if you approve then I'll merge. |
Thanks @HumphreyYang , nice work. My only comment is that in #230 I suggested "adding a second part to the exercise where 4 is replaced by a large number and the reader is asked to time a for loop against the broadcast implementation." In other words, the reader first replicates on a small example to make sure that they are getting the same result, and then tests the two versions on a larger example to investigate timing. Do you think this is worthwhile? |
Hi @jstac, I have added back the sample example. Could you have another look at the newest deployment? Many thanks. |
Perfect. Thanks @HumphreyYang! Merging. |
Hi @mmcky,
This resolves #230. Could you please kindly review this PR and let me know if there is anything I could change?
Many thanks