Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Performance Evaluation to Numpy Exercise #235

Merged
merged 8 commits into from
Oct 5, 2022
Merged

Adding Performance Evaluation to Numpy Exercise #235

merged 8 commits into from
Oct 5, 2022

Conversation

HumphreyYang
Copy link
Collaborator

Hi @mmcky,

This resolves #230. Could you please kindly review this PR and let me know if there is anything I could change?

Many thanks

@mmcky
Copy link
Contributor

mmcky commented Oct 2, 2022

thanks @HumphreyYang I think this is a good addition.

@mmcky
Copy link
Contributor

mmcky commented Oct 2, 2022

@jstac if you approve then I'll merge.

@mmcky mmcky requested a review from jstac October 2, 2022 23:08
@jstac
Copy link
Contributor

jstac commented Oct 4, 2022

Thanks @HumphreyYang , nice work.

My only comment is that in #230 I suggested "adding a second part to the exercise where 4 is replaced by a large number and the reader is asked to time a for loop against the broadcast implementation."

In other words, the reader first replicates on a small example to make sure that they are getting the same result, and then tests the two versions on a larger example to investigate timing.

Do you think this is worthwhile?

@github-actions github-actions bot temporarily deployed to commit October 4, 2022 22:57 Inactive
@github-actions github-actions bot temporarily deployed to commit October 4, 2022 23:04 Inactive
@github-actions github-actions bot temporarily deployed to commit October 4, 2022 23:16 Inactive
@github-actions github-actions bot temporarily deployed to commit October 5, 2022 10:33 Inactive
@HumphreyYang
Copy link
Collaborator Author

Hi @jstac,

I have added back the sample example. Could you have another look at the newest deployment?

Many thanks.

@jstac
Copy link
Contributor

jstac commented Oct 5, 2022

Perfect. Thanks @HumphreyYang! Merging.

@jstac jstac merged commit a60b34a into main Oct 5, 2022
@jstac jstac deleted the numpy-time branch October 5, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add speed comparison for broadcasting exercise in NumPy lecture
3 participants