Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lecture_comparison][38_wald_friedman]math_expression_in_indented_sentence #48

Closed
sayaikegawa opened this issue Jan 19, 2021 · 5 comments · Fixed by #105
Closed

[lecture_comparison][38_wald_friedman]math_expression_in_indented_sentence #48

sayaikegawa opened this issue Jan 19, 2021 · 5 comments · Fixed by #105

Comments

@sayaikegawa
Copy link

sayaikegawa commented Jan 19, 2021

In this lecture, the math equation in the quotes shows redundant > at the beginning and the ending of the equation like below.
Left: RST Right: MyST

Screen Shot 2021-01-19 at 5 12 48 pm

Here is the place where this issue occurs in MyST:

> Neyman and Pearson show that a region consisting of all samples
> $(z_1, z_2, \ldots, z_n)$ which satisfy the inequality
> 
> $$
> \frac{ f_1(z_1) \cdots f_1(z_n)}{f_0(z_1) \cdots f_0(z_n)} \geq k
> $$
> 
> is a most powerful critical region for testing the hypothesis

I guess that this occurs because the quotes in MyST is doing something wrong. Here is the documentation about quotes.
Screen Shot 2021-01-19 at 5 23 15 pm

cc: @mmcky

@sayaikegawa
Copy link
Author

This happens in lecture-python-advanced too. #16

@mmcky
Copy link
Contributor

mmcky commented Feb 8, 2021

thanks @sayaikegawa are you suggesting then we should have:

> Neyman and Pearson show that a region consisting of all samples
> $(z_1, z_2, \ldots, z_n)$ which satisfy the inequality
> 
> $$
   \frac{ f_1(z_1) \cdots f_1(z_n)}{f_0(z_1) \cdots f_0(z_n)} \geq k
   $$
> 
> is a most powerful critical region for testing the hypothesis

as the syntax? -- I find that an odd choice. I may need to talk with Jupyter Book about this.

@mmcky
Copy link
Contributor

mmcky commented Feb 8, 2021

Nice pickup! this will be useful for the broader juptyer-book project as I think it should be capable of rendering the former syntax. If we could get a minimal example working in jupyter-book that would be super helpful.

@mmcky
Copy link
Contributor

mmcky commented Feb 10, 2021

@sayaikegawa can you put together a PR to fix this and tag it as manual-change. Thanks!

@mmcky
Copy link
Contributor

mmcky commented Feb 16, 2021

Closing this as a solution is ready as a PR.

@mmcky mmcky closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants