Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Parameters Pass #135

Closed
5 of 54 tasks
arnavs opened this issue Sep 28, 2018 · 8 comments
Closed
5 of 54 tasks

Parameters Pass #135

arnavs opened this issue Sep 28, 2018 · 8 comments
Assignees
Milestone

Comments

@arnavs
Copy link
Member

arnavs commented Sep 28, 2018

Wherever possible, replace structs that we're using as parameter containers with NamedTuples (and the related constructors) from Parameters.jl. This issue binds to a large number of lectures, and involves a significant refactoring.

Active template for checklists:

Getting Started with Julia

More Programming and Software Engineering Principles

Tools and Techniques

Dynamic Programming

Multiple Agent Models

Time Series Models

Dynamic Programming Squared

@jlperla
Copy link
Member

jlperla commented Sep 28, 2018

Lets remove this, since the parameters is not something that can be don in a pass, but requirs a complete rewrite.

@jlperla jlperla closed this as completed Sep 28, 2018
@jlperla
Copy link
Member

jlperla commented Oct 2, 2018

I am reopening this. With the current strategy, I think we may end up doing more passes and less of a full-rewrite-at-once approach.

@jlperla jlperla reopened this Oct 2, 2018
@arnavs arnavs mentioned this issue Oct 16, 2018
10 tasks
@arnavs
Copy link
Member Author

arnavs commented Oct 22, 2018

@ajozefiak Let's talk about this issue today if you have time.

@jlperla
Copy link
Member

jlperla commented Oct 30, 2018

I removed teh v1.0 release because we will have to ship without it, but we want to do it soon.

@arnavs
Copy link
Member Author

arnavs commented Nov 2, 2018

@ajozefiak Are you out of things to do on this repo? I'm curious- take a look at the existing open PRs for this. If they make sense (basically, remove structs that aren't used for dispatch/replace them with namedtuples; can cannibalize existing shorthand constructors) maybe take a stab at cleaning up a few of the remaining ones.

@ajozefiak
Copy link
Member

@arnavs Sure I'll have a look at these.

@jlperla jlperla modified the milestones: v1.1, v1.0 Nov 8, 2018
@jlperla
Copy link
Member

jlperla commented Nov 11, 2018

Is this checklist up to date for the Parameters pass?

@arnavs
Copy link
Member Author

arnavs commented Nov 16, 2018

Checklist is out of date, will consolidate on one issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants