Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Maximize pass #158

Closed
jlperla opened this issue Oct 5, 2018 · 5 comments
Closed

Maximize pass #158

jlperla opened this issue Oct 5, 2018 · 5 comments
Milestone

Comments

@jlperla
Copy link
Member

jlperla commented Oct 5, 2018

Optim.jl now supports the univariate maximize function instead of just optimize

We should find all of the places that use optimize and convert to maximize if that is the math implementation. Of course, since this si a move from minimize to maximize, this means swapping the sign of the objective that is passed in as well not swapping the sign of the output

Also, look for http://quantecon.github.io/QuantEcon.jl/latest/api/QuantEcon.html#QuantEcon.golden_method-Tuple{Function,Real,Real} and swap that out as well.

@arnavs
Copy link
Member

arnavs commented Oct 11, 2018

@XiaojunGuan I think this is a good one to start on. Basically, we have a lot of maximization problems that are coerced into the structure of a minimization problem, because that's what Optim.jl used to support. But now that we've got maximize, we can write them more naturally.

JuliaNLSolvers/Optim.jl#554 is some background on the optimizer, but to see the exact usage you can look at the tests in the Optim package.

@XiaojunGuan XiaojunGuan reopened this Oct 16, 2018
@arnavs arnavs mentioned this issue Oct 16, 2018
10 tasks
@arnavs arnavs assigned arnavs and unassigned XiaojunGuan Oct 17, 2018
@arnavs
Copy link
Member

arnavs commented Oct 17, 2018

There are 3 left which @XiaojunGuan is having trouble with, so I'll take those.

@arnavs arnavs removed their assignment Oct 22, 2018
@Nosferican
Copy link
Collaborator

ifp.rst needs a pass.

@Nosferican
Copy link
Collaborator

Any update on that?

@jlperla jlperla added this to the v1.0 launch milestone Nov 8, 2018
@arnavs
Copy link
Member

arnavs commented Nov 9, 2018

Done at e4697c6; thanks for the reminder @Nosferican.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants