minor fixes in tax_smoothing_1.rst #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natashawatkins thanks. I will do the suggested changes. |
|
@natashawatkins what should be the Title or the heading of this lecture? |
|
|
||
| The class also contains a “method”, for simulating the model. This is an | ||
| extension of a similar method in the LQ class, adapted to take into | ||
| account the fact that the model’s matrices depend on the state of the | ||
| world. | ||
| world | ||
|
|
||
| Below we import all functionality from this code. | ||
|
|
||
| (You should download `the | ||
| file <https://github.com/QuantEcon/TaxSmoothing/blob/master/lq_markov.py>`__ |
There was a problem hiding this comment.
Would you be able to implement this function (https://quanteconpy.readthedocs.io/en/latest/util/notebooks.html) and place the file in QuantEcon.Notebooks
source/rst/tax_smoothing_1.rst
Outdated
| We begin by solving a version of the Barro (1979) model by mapping it | ||
| into the original LQ framework. As mentioned `in this | ||
| lecture <http://lectures.quantecon.org/py/perm_income_cons.html>`__, the | ||
| As mentioned `in this lecture <http://lectures.quantecon.org/py/perm_income_cons.html>`__, the |
There was a problem hiding this comment.
we have :doc:`` directive to refer to other lectures
|
@natashawatkins I will do all the suggested changes. |
natashawatkins
requested changes
May 16, 2019
source/rst/tax_smoothing_1.rst
Outdated
| @@ -12,7 +12,7 @@ How to Pay for a War: Part 1 | |||
|
|
|||
| .. contents:: :depth: 2 | |||
|
|
|||
| **Co-author: Sebastian Graves <https://github.com/sebgraves> ** | |||
| **Co-author**: `Sebastian Graves <https://github.com/sebgraves>`__ | |||
There was a problem hiding this comment.
could you keep it bolded though?
source/rst/tax_smoothing_1.rst
Outdated
| @@ -23,7 +23,7 @@ This notebook constructs generalizations of Barro’s classic 1979 :cite:`Barro1 | |||
| of tax smoothing | |||
|
|
|||
| Our generalizations are adaptations of extensions of | |||
| his 1979 model suggested by Barro (1999, 2003) | |||
| his 1979 model suggested by Barro (1999, 2003) :cite:`barro2003religion` | |||
There was a problem hiding this comment.
can you cite both papers here
source/rst/tax_smoothing_1.rst
Outdated
| @@ -518,7 +518,7 @@ To implement the extension to the Barro model in which :math:`p_{t,t+1}` | |||
| varies over time, we must allow the M matrix to be time-varying. From | |||
| the mapping of the Barro model into the ``LQ`` framework, this means that | |||
There was a problem hiding this comment.
LQ shouldn't be highlighted here
| @@ -138,11 +147,11 @@ This notebook describes: | |||
|
|
|||
| A `sequel to this | |||
| notebook <https://github.com/QuantEcon/TaxSmoothing/blob/master/Tax_Smoothing_2.ipynb>`__ | |||
| describes applies Markov LQ control to settings in which a government | |||
| describes applies Markov ``LQ`` control to settings in which a government | |||
There was a problem hiding this comment.
this shouldn't be highlighted
| @@ -138,11 +147,11 @@ This notebook describes: | |||
|
|
|||
| A `sequel to this | |||
| notebook <https://github.com/QuantEcon/TaxSmoothing/blob/master/Tax_Smoothing_2.ipynb>`__ | |||
There was a problem hiding this comment.
can you use :doc:`` to refer to other lectures
|
|
||
| To map into the LQ framework, we will use | ||
| To map into the ``LQ`` framework, we will use |
There was a problem hiding this comment.
shouldn't be highlighted
| R[0, 0] = R[0, 0] + 1e-9 | ||
|
|
||
| We can now create an instance of an LQ model: | ||
| We can now create an instance of an ``LQ`` model: |
There was a problem hiding this comment.
shouldn't be highlighted
|
|
||
| LQBarro = qe.LQ(Q, R, A, B, C=C, N=W, beta=β) | ||
| P, F, d = LQBarro.stationary_values() | ||
| x0 = np.array([[100, 1, 25]]) | ||
|
|
||
| We can see the isomorphism by noting that consumption is a martingale in | ||
| the permanent income model, and that taxation is a martingale in Barro’s | ||
| model. We can check this using the F matrix of the LQ model. As | ||
| model. We can check this using the :math:`F` matrix of the ``LQ`` model. As |
There was a problem hiding this comment.
new line + shouldn't be highlighted
| @@ -489,9 +499,9 @@ Barro model a large number of times: | |||
|
|
|||
| We can see a similar, but smoother pattern, if we plot government debt | |||
| over time. Debt is smoother due to the persistence of the government | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.