Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add support for solutions class #72

Merged
merged 3 commits into from Aug 29, 2018
Merged

FEAT: Add support for solutions class #72

merged 3 commits into from Aug 29, 2018

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Aug 21, 2018

This PR adds the capability to specify a code block as a solution using :class: solution. These solution blocks can then be included or excluded during the conversion from RST to IPYNB.

  • add tests

@mmcky
Copy link
Contributor Author

mmcky commented Aug 28, 2018

  • figure out how to test this with and without solutions - through adjustments to conf.py.

Can we introduce a context manager? We will also need to know what to compare so may need to introduce a configuration matrix such that:

jupyter_drop_solutions = True  :  solutions_2.ipynb

otherwise we can generate conf.py from a template and use yaml for specifying a CI configuration set of tests:

A:
   sphinxcontrib-jupyter:
        options : { jupyter_drop_solutions = True }
        ipynb : {solutions_2.ipynb }

@mmcky
Copy link
Contributor Author

mmcky commented Aug 29, 2018

merging this now to allow development of a related feature for adding code test blocks. Merging this will prevent a future merge conflict. @arnavs you can still view the diff of this PR from the closed list. I will add an issue for testing improvements.

@mmcky mmcky merged commit af85db8 into master Aug 29, 2018
@mmcky mmcky deleted the add-solutions branch August 29, 2018 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant