Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for note node type as blockquote markdown #81

Merged
merged 4 commits into from Sep 4, 2018

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Sep 3, 2018

fixes #80

  • add tests
  • update documentation

@mmcky
Copy link
Contributor Author

mmcky commented Sep 3, 2018

this PR is impacting on code_blocks rendering.

  • review code_blocks test

This is currently failing as the code_blocks tests for code blocks that are contained in notes

.. NOTE::

   A code block in a note::

       >>> 1+1

   Another one::

       >>> 1+1

the current reference IPYNB actually ignores the note. Current implementation in this PR includes the contents of the note as raw text which is problematic when it contains code.

@mmcky
Copy link
Contributor Author

mmcky commented Sep 4, 2018

I will merge this PR with the known limitation that note can currently only contain raw and direct markdown convertible text and open an issue to support embedded directives.

@mmcky mmcky merged commit 1383684 into master Sep 4, 2018
@mmcky mmcky deleted the add-note-support branch September 4, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT: Add support for note directive in documents
1 participant