Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/dist AMD modules not published #230

Closed
jasongrout-db opened this issue Aug 5, 2022 · 4 comments · Fixed by #232
Closed

/dist AMD modules not published #230

jasongrout-db opened this issue Aug 5, 2022 · 4 comments · Fixed by #232

Comments

@jasongrout-db
Copy link

Looking at https://www.jsdelivr.com/package/npm/ipysheet, it appears that the dist/ directory with AMD modules is not being published with the package, which means that the html manager (and currently Voila?) cannot use ipysheet by loading it from CDN. I think this also may affect using it in Colab and Databricks, and maybe VS Code as well?

Fixing this may be as simple as adding the dist/ directory to the package.json files field: https://github.com/QuantStack/ipysheet/blob/master/package.json#L19

@jasongrout
Copy link
Contributor

I put in a PR for this change at #232

@jasongrout-db
Copy link
Author

Thanks @martinRenou. Do you have a timeline for when a new npm package might be published that includes this dist directory?

@mrileysamc
Copy link

@jasongrout , do you think this resolves issues holoviz/panel#2633 and bokeh/ipywidgets_bokeh#54 as well?

@mrileysamc
Copy link

mrileysamc commented Oct 18, 2022

It's working!!!! Thank you @martinRenou and @jasongrout-db !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants