-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to JupyterLab 3 #33
Conversation
Thanks! Just rebased onto the latest master. |
Thanks a lot Jeremy |
setup.py
Outdated
|
||
# The name of the project | ||
name="jupyterlab-snippets" | ||
name = "jupyterlab_snippets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep jupyterlab-snippets
here? (purely for esthetics reasons)
And maybe use:
package = name.replace('-', '_')
For the folder and package names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I made the modification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Fixes #32