Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename xadapt() -> adapt() #563

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

stuarteberg
Copy link
Contributor

@stuarteberg stuarteberg commented Nov 27, 2017

Fixes #546

Technically, this is a breaking change, albeit a small one. Does that mean it should wait until the next major release?

cc @constantinpape

details
# Rename xadapt -> adapt
$ git grep -l xadapt | xargs sed -i '' 's/xadapt\([^a-zA-Z.]\)/adapt\1/g'

# Note: Header name is unchanged.
$ git grep xadapt
CMakeLists.txt:    ${XTENSOR_INCLUDE_DIR}/xtensor/xadapt.hpp
docs/source/adaptor.rst:    #include "xtensor/xadapt.hpp"
docs/source/adaptor.rst:    #include "xtensor/xadapt.hpp"
docs/source/adaptor.rst:    #include "xtensor/xadapt.hpp"
docs/source/api/xarray_adaptor.rst:Defined in ``xtensor/xadapt.hpp``
docs/source/api/xtensor_adaptor.rst:Defined in ``xtensor/xadapt.hpp``
docs/source/external-structures.rst:``xadaptor_semantic`` instead.
include/xtensor/xnpy.hpp:#include "xtensor/xadapt.hpp"
test/CMakeLists.txt:    test_xadapt.cpp
test/CMakeLists.txt:    test_xadaptor_semantic.cpp
test/test_xadapt.cpp:#include "xtensor/xadapt.hpp"

@JohanMabille
Copy link
Member

JohanMabille commented Nov 28, 2017

Hi Stuart,

Thanks for fixing this! It is not a problem to merge it now since we plan to add other breaking changes and make a major release shortly (I should say minor actually, since that will be 0.14.0).

@JohanMabille JohanMabille merged commit ab21f9e into xtensor-stack:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants