Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Reduce duplication in the Cython/C++ for sandwich and dot products. #221

Closed
tbenthompson opened this issue Jun 23, 2020 · 1 comment

Comments

@tbenthompson
Copy link
Collaborator

tbenthompson commented Jun 23, 2020

There are several places where there's a lot of duplication: dense.pyx, dense_helpers-tmpl.cpp, categorical.pyx.

I'm not sure how feasible or reasonable it is to reduce this. It's going to be hard to do so without impacting performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants