We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copied from Quantco/glum#221
There are several places where there's a lot of duplication: dense.pyx, dense_helpers-tmpl.cpp, categorical.pyx.
I'm not sure how feasible or reasonable it is to reduce this. It's going to be hard to do so without impacting performance.
The text was updated successfully, but these errors were encountered:
See #107 and #108
Sorry, something went wrong.
Hi, are you accepting external contributions?
@jjerphan Yes, we are happy to receive external contributions.
Thanks for the information.
To me, it looks like the duplication in the files that are mentioned hardly can be removed without introducing extra complexity.
Yet, I think a few things might be simplified or improved in the code-base.
For now, I started with #245, a super minimalistic PR.
No branches or pull requests
Copied from Quantco/glum#221
There are several places where there's a lot of duplication: dense.pyx, dense_helpers-tmpl.cpp, categorical.pyx.
I'm not sure how feasible or reasonable it is to reduce this. It's going to be hard to do so without impacting performance.
The text was updated successfully, but these errors were encountered: