Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication in the Cython/C++ for sandwich and dot products. #5

Closed
ElizabethSantorellaQC opened this issue Jul 9, 2020 · 4 comments

Comments

@ElizabethSantorellaQC
Copy link
Contributor

Copied from Quantco/glum#221

There are several places where there's a lot of duplication: dense.pyx, dense_helpers-tmpl.cpp, categorical.pyx.

I'm not sure how feasible or reasonable it is to reduce this. It's going to be hard to do so without impacting performance.

@tbenthompson
Copy link
Collaborator

See #107 and #108

@jjerphan
Copy link
Contributor

jjerphan commented Apr 6, 2023

Hi, are you accepting external contributions?

@xhochy
Copy link
Member

xhochy commented Apr 6, 2023

@jjerphan Yes, we are happy to receive external contributions.

@jjerphan
Copy link
Contributor

jjerphan commented Apr 9, 2023

Thanks for the information.

To me, it looks like the duplication in the files that are mentioned hardly can be removed without introducing extra complexity.

Yet, I think a few things might be simplified or improved in the code-base.

For now, I started with #245, a super minimalistic PR.

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants