Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSet.crosstab should support lists #1216

Open
jamesrkg opened this issue Jan 28, 2019 · 9 comments
Open

DataSet.crosstab should support lists #1216

jamesrkg opened this issue Jan 28, 2019 · 9 comments

Comments

@jamesrkg
Copy link
Contributor

Any of these should be possible via auto-pd.concat:

dataset.crosstab(['q1', 'q2'], 'q3')
dataset.crosstab('q1', ['q2', 'q3'])
dataset.crosstab(['q1', 'q2'], ['q3', 'q4'])

@nitsrek
Copy link
Contributor

nitsrek commented Feb 1, 2019

additionally a few new features are added (like adding stats + sigs)

@jamesrkg
Copy link
Contributor Author

jamesrkg commented Feb 1, 2019

ALL THE THINGS!

@nitsrek
Copy link
Contributor

nitsrek commented Feb 1, 2019

tests are failing for chains. need to check next week!

@nitsrek
Copy link
Contributor

nitsrek commented Feb 5, 2019

to get all old functionalities, rbase is needed (draft for ViewManager regarding rbase is added).
ChainManager does not support rbase yet, Chain.get() does not merge the frames properly. @alextanski can we have a look together?

@nitsrek
Copy link
Contributor

nitsrek commented Feb 6, 2019

@alextanski branch i1216_dataset_crosstab is up-to-date

DataSet.crosstab2() is my new crosstab version, which currently ignores rbase

ViewManager.set_bases() is updated, so it takes rbase into account if requested

@Segweigh
Copy link

I'm a big user of DataSet.crosstab I really like it. I second the request about, it would be good to have the option to hide rbase, but also to show weighted and unwieghted rbase counts (even on % crosstabs)

@Havlin
Copy link

Havlin commented Apr 21, 2019

Sorry I'm a little confuesed by the thread. Are people saying that their currently is a way to do lists in cross-tabs (like in Pandas) or are they saying that their should be in the future? If it's currently possible could someone provide me with some additional guidance?

@nitsrek
Copy link
Contributor

nitsrek commented Apr 23, 2019

@Havlin in the current master or develop version crosstab does not support lists, but it should be possible in future.

Currently there is a new crosstab method DataSet.crosstab2() in branch i1216_dataset_crosstab, that does support lists, but it's not fully tested and row-bases (which are available in the current method) are not working.

@Havlin
Copy link

Havlin commented Jun 23, 2019

Thanks @nitsrek . What do you mean by 'row-bases'? Do you mean that it doesn't provide totals in the table?

Also, are there any significant diffirences between i1216 and master other than crosstabs? I have some files on my machine written with a lot of quantipy master and wasn't sure if their might be some semantic errors if I start using all of i1216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants