Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openjdk 16 #94

Merged
merged 3 commits into from Aug 14, 2020
Merged

Add openjdk 16 #94

merged 3 commits into from Aug 14, 2020

Conversation

cap10morgan
Copy link
Collaborator

@cap10morgan cap10morgan commented Aug 13, 2020

New JDK version added. I also gave the README a refresh pass. I also snuck in a small enhancement that pulls upstream images before building on them. I noticed that sometimes builds would be different on my local machine if I had an outdated upstream openjdk image already cached. This helps ensure (but does not guarantee) that my local builds are the same as what will get built on the Docker image infrastructure.

After this I'm going to work on reverting our tools-deps images to stable releases only, which I recently learned were a thing: https://groups.google.com/u/2/g/clojure/c/cS8KjpTKBl0

Copy link
Owner

@Quantisan Quantisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @cap10morgan

@cap10morgan cap10morgan merged commit 72b950a into master Aug 14, 2020
@cap10morgan cap10morgan deleted the add/openjdk-16 branch August 14, 2020 10:58
@cap10morgan
Copy link
Collaborator Author

Official library PR: docker-library/official-images#8558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants