Merge pull request #212 from dlyongemallo/full_reduce_error_not_zx_di…

…agram

In `full_reduce`, raise error if input graph contains `H_BOX`.

pyzx/simplify.py

@@ -196,6 +196,9 @@ def reduce_scalar(g: BaseGraph[VT,ET], quiet:bool=True, stats:Optional[Stats]=No
 def full_reduce(g: BaseGraph[VT,ET], quiet:bool=True, stats:Optional[Stats]=None) -> None:
     """The main simplification routine of PyZX. It uses a combination of :func:`clifford_simp` and
     the gadgetization strategies :func:`pivot_gadget_simp` and :func:`gadget_simp`."""
+    if any(g.types()[h] == VertexType.H_BOX for h in g.vertices()):
+        raise ValueError("Input graph is not a ZX-diagram as it contains an H-box. "
+                         "Maybe call pyzx.hsimplify.from_hypergraph_form(g) first?")
     interior_clifford_simp(g, quiet=quiet, stats=stats)
     pivot_gadget_simp(g,quiet=quiet, stats=stats)
     while True:

tests/test_simplify.py

@@ -1,4 +1,4 @@
-# PyZX - Python library for quantum circuit rewriting 
+# PyZX - Python library for quantum circuit rewriting
 #        and optimization using the ZX-calculus
 # Copyright (C) 2018 - Aleks Kissinger and John van de Wetering
 
@@ -21,6 +21,8 @@
 from types import ModuleType
 from typing import Optional
 
+from pyzx import VertexType
+
 if __name__ == '__main__':
     sys.path.append('..')
     sys.path.append('.')
@@ -113,6 +115,21 @@ def test_to_graph_like_introduce_boundary_vertices(self):
         to_graph_like(g)
         self.assertTrue(compare_tensors(c,g))
 
+    def test_full_reduce_with_h_box(self):
+        """Test that calls to :func:`full_reduce` with a graph containing H-boxes raises an error.
+        This is a common mistake made by users (e.g., see issues #161 and #200).
+        """
+        g = Graph()
+        v0 = g.add_vertex(VertexType.BOUNDARY, 0, 0)
+        v1 = g.add_vertex(VertexType.H_BOX, 0, 1)
+        v2 = g.add_vertex(VertexType.BOUNDARY, 0, 2)
+        g.add_edge((v0, v1))
+        g.add_edge((v1, v2))
+
+        with self.assertRaises(ValueError) as context:
+            full_reduce(g)
+        self.assertTrue("Input graph is not a ZX-diagram" in str(context.exception))
+
 
 qasm_1 = """OPENQASM 2.0;
 include "qelib1.inc";