Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting changes with a context handler #2127

Merged
merged 9 commits into from
May 12, 2024
Merged

Add support for setting changes with a context handler #2127

merged 9 commits into from
May 12, 2024

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented May 12, 2024 •
edited
Loading

Summary of Changes

Adds the ability to change settings temporarily via a context handler.

Closes #2119.

Checklist

  • I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
  • My PR is on a custom branch and is not named main.
  • I have added relevant, comprehensive unit tests.

Notes

  • Your PR will likely not be merged without proper and thorough tests.
  • If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
  • When your code is ready for review, ping one of the active maintainers.

@Andrew-S-Rosen Andrew-S-Rosen enabled auto-merge (squash) May 12, 2024 07:15
@Andrew-S-Rosen Andrew-S-Rosen merged commit f10d15c into main May 12, 2024
16 of 17 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the settingshandler branch May 12, 2024 07:43
@Andrew-S-Rosen Andrew-S-Rosen mentioned this pull request May 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a monkeypatching approach for modifying SETTINGS in the test runs
1 participant
@Andrew-S-Rosen