Fix for result validation; Error in usage example #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menu tests don't work, since request() form REPL.TerminalMenus is called in a script. Also, stdin is type IOStream in the script and has no field buffer. In REPL stdin is Base.TTY.
Adding meas_level and curc_id keys to the ExpResult schema.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
===========================================
- Coverage 83.63% 64.64% -19.00%
===========================================
Files 4 5 +1
Lines 275 280 +5
===========================================
- Hits 230 181 -49
- Misses 45 99 +54 ☔ View full report in Codecov by Sentry. |
|
Great Job! Thanks for the hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the usage example from the docs, there is an error when downloading the result.
Fixed it by adding meas_level and curc_id keys to the ExpResult schema.
Also, commented out menu tests until further investigation.